-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(agent): filter out empty params to ensure LLM can set tool params at runtime #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryFixes a bug where user-cleared form fields (empty strings
The fix is consistent with the existing Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant UI as User Interface
participant State as UI State
participant PrepTool as prepareToolExecution
participant MergeTool as mergeToolParameters
participant LLM as LLM Agent
UI->>State: User sets field value
UI->>State: User clears field (becomes '')
State->>PrepTool: tool.params (includes '')
LLM->>PrepTool: llmArgs (generated values)
PrepTool->>PrepTool: Filter out empty/null/undefined
PrepTool->>PrepTool: Merge filtered params with llmArgs
Note over PrepTool: LLM values preserved for cleared fields
alt Custom Tool Path
State->>MergeTool: userProvidedParams (includes '')
LLM->>MergeTool: callParams (generated values)
MergeTool->>MergeTool: Filter out empty/null/undefined
MergeTool->>MergeTool: Merge filtered params with callParams
Note over MergeTool: LLM values preserved for cleared fields
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
* feat(folders): add the ability to create a folder within a folder in popover (#2287) * fix(agent): filter out empty params to ensure LLM can set tool params at runtime (#2288) * fix(mcp): added backfill effect to add missing descriptions for mcp tools (#2290) * fix(redis): cleanup access pattern across callsites (#2289) * fix(redis): cleanup access pattern across callsites * swap redis command to be non blocking * improvement(log-details): polling, trace spans (#2292) --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Summary
Type of Change
Testing
Tested manually
Checklist